Deprecate sequence from physical mesh axes#3722
Merged
copybara-service[bot] merged 1 commit intomainfrom Apr 23, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
NuojCheng
force-pushed
the
chengnuojin-bye-sequence
branch
5 times, most recently
from
5e6e7d9 to
52ff5ef
Compare
NuojCheng
requested review from
A9isha,
NicoGrande,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jesselu-google,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
suexu1025 and
vipannalla
as code owners
gobbleturk
approved these changes
Apr 22, 2026
Collaborator
gobbleturk
left a comment
gobbleturk
left a comment
There was a problem hiding this comment.
You should also update our documentation at sharding.md
gobbleturk
reviewed
Apr 22, 2026
Collaborator
gobbleturk
left a comment
gobbleturk
left a comment
There was a problem hiding this comment.
What about removing sequence from the model code e.g. attention.py?
bvandermoon
approved these changes
Apr 22, 2026
Collaborator
LGTM pending this comment |
NuojCheng
force-pushed
the
chengnuojin-bye-sequence
branch
from
52ff5ef to
e4ea4cc
Compare
Collaborator
Author
Could you elaborate more on sequence from the model code? I don't think we have sequence explicitly mentioned in the model code, as they are governed by the logical rule. @gobbleturk |
NuojCheng
force-pushed
the
chengnuojin-bye-sequence
branch
from
e4ea4cc to
e0f17a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR deprecates
sequencemesh axis, which maxtext no longer uses.Tests
CI
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.